fix: remove flaky 400 assertion in dropNotifications test - #6
Merged
Conversation
The DELETE /notifications endpoint always returns 200 OK for non-existent IDs (uses INSERT...ON CONFLICT DO NOTHING), so expecting a 400 for id '0' was never a valid assumption. Skip the test when there are no notifications to drop instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dropNotificationstest expected a 400 when passing a bogus notification ID ('0') with an empty account/notificationsendpoint always returns 200 OK for non-existent IDs — it usesINSERT INTO fe_notifications_read ... ON CONFLICT DO NOTHING, so unknown IDs silently no-opidsis missing or empty, not when IDs don't existTest plan
pnpm test:client—dropNotificationstest should no longer flakeNote
Low Risk
Low risk: changes only a client test to avoid asserting an API error status that may legitimately not occur, reducing flakiness without affecting runtime behavior.
Overview
Removes the
dropNotificationstest assertion that a bogus notification ID returns400when the account has no notifications; the test now simply returns early in that situation.This reduces flakiness by only exercising the happy path where real notification IDs exist and are verified to clear.
Reviewed by Cursor Bugbot for commit e352b0e. Bugbot is set up for automated code reviews on this repo. Configure here.